Closed
Bug 1106665
Opened 11 years ago
Closed 10 years ago
text-align:justify doesn't work in vertical writing-mode
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
1.91 KB,
text/html
|
Details | |
|
1.59 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
See attached testcase. The "justify" option works fine horizontally, but does nothing vertically.
|
Assignee | |
Comment 1•11 years ago
|
||
This one's a trivial fix. :)
Attachment #8531016 -
Flags: review?(smontagu)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
Simplified by using mFrame->ISize().
Attachment #8531292 -
Flags: review?(smontagu)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8531016 -
Attachment is obsolete: true
Attachment #8531016 -
Flags: review?(smontagu)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8531016 [details] [diff] [review]
Fix text-align:justify for vertical writing modes
Review of attachment 8531016 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/generic/nsTextFrame.cpp
@@ +3391,5 @@
> naturalWidth += GetHyphenWidth();
> }
> + mJustificationSpacing =
> + (mTextRun->IsVertical() ? mFrame->GetSize().height
> + : mFrame->GetSize().width) - naturalWidth;
mJustificationSpacing = mFrame->ISize() - naturalWidth;
Attachment #8531016 -
Attachment is obsolete: false
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8531292 [details] [diff] [review]
Fix text-align:justify for vertical writing modes
Review of attachment 8531292 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with that change
Attachment #8531292 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Target Milestone: --- → mozilla37
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8531016 -
Attachment is obsolete: true
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•